Use prepared statements to replace sql#3037
Merged
Merged
Conversation
killing
reviewed
Jun 11, 2026
| if (sqlite_query_exec (session->config_db, sql) < 0) | ||
| if (sqlite_query_exec (session->config_db, | ||
| "REPLACE INTO Config VALUES (?, ?)", | ||
| 2, "string", key, "int", value) < 0) |
Member
There was a problem hiding this comment.
value 的类型应该是 text。这里的代码应该本来就不是很对，直接传入了一个 int，只是 SQLite 应该自动做了类型转换。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.